Skip to content

Commit

Permalink
Fix a const pointer usage warning in the Digigram VX soundcard driver
Browse files Browse the repository at this point in the history
Fix a const pointer usage warning in the Digigram VX soundcard driver.  A
const pointer is being passed to copy_from_user() to load the firmware into.
This is okay in this case because the function has allocated the firmware
struct itself, but the const qualifier will be part of the firmware 
struct - so the patch casts the const away.

Signed-off-by: David Howells <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
  • Loading branch information
dhowells authored and David Woodhouse committed Jul 10, 2008
1 parent ed5a282 commit b561c74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/drivers/vx/vx_hwdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ static int vx_hwdep_dsp_load(struct snd_hwdep *hw,
kfree(fw);
return -ENOMEM;
}
if (copy_from_user(fw->data, dsp->image, dsp->length)) {
if (copy_from_user((void *)fw->data, dsp->image, dsp->length)) {
free_fw(fw);
return -EFAULT;
}
Expand Down

0 comments on commit b561c74

Please sign in to comment.