tpm: Properly clean sysfs entries in error path

Properly clean the sysfs entries in the error path Cc: <[email protected]> Reported-by: Dmitry Kasatkin <[email protected]> Signed-off-by: Stefan Berger <[email protected]> Reviewed-by: Jason Gunthorpe <[email protected]> Signed-off-by: Peter Huewe <[email protected]>
mrcsosa · Jul 29, 2014 · b49e104 · b49e104
1 parent f07a5e9
commit b49e104
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
@@ -1095,7 +1095,7 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,
 		goto del_misc;
 
 	if (tpm_add_ppi(&dev->kobj))
-		goto del_misc;
+		goto del_sysfs;
 
 	chip->bios_dir = tpm_bios_log_setup(chip->devname);
 
@@ -1106,6 +1106,8 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,
 
 	return chip;
 
+del_sysfs:
+	tpm_sysfs_del_device(chip);
 del_misc:
 	tpm_dev_del_device(chip);
 put_device: