Skip to content

Commit

Permalink
IB/mthca: Fix lid used for sending traps
Browse files Browse the repository at this point in the history
The SM LID used to send traps to is incorrectly set to port LID.  This
is a regression from 2.6.17 -- after a PortInfo MAD is received, no
traps are sent to the SM LID.  The traps go to the loopback interface
instead, and are dropped there.  The SM LID should be taken from the
sm_lid of the PortInfo response.

The bug was introduced by commit 12bbb2b:
	IB/mthca: Add client reregister event generation

Signed-off-by: Jack Morgenstein <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Roland Dreier <[email protected]>
  • Loading branch information
Jack Morgenstein authored and Roland Dreier committed Sep 22, 2006
1 parent e6e5fee commit b270757
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_mad.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ static void smp_snoop(struct ib_device *ibdev,

mthca_update_rate(to_mdev(ibdev), port_num);
update_sm_ah(to_mdev(ibdev), port_num,
be16_to_cpu(pinfo->lid),
be16_to_cpu(pinfo->sm_lid),
pinfo->neighbormtu_mastersmsl & 0xf);

event.device = ibdev;
Expand Down

0 comments on commit b270757

Please sign in to comment.