forked from analogdevicesinc/linux
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use kstrdup rather than duplicating its implementation Signed-off-by: Nicolas Palix <[email protected]> Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Michal Marek <[email protected]>
- Loading branch information
Showing
1 changed file
with
39 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/// Use kstrdup rather than duplicating its implementation | ||
/// | ||
// Confidence: High | ||
// Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
// Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
// Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
// URL: http://coccinelle.lip6.fr/ | ||
// Comments: | ||
// Options: -no_includes -include_headers | ||
|
||
virtual patch | ||
|
||
@@ | ||
expression from,to; | ||
expression flag,E1,E2; | ||
statement S; | ||
@@ | ||
|
||
- to = kmalloc(strlen(from) + 1,flag); | ||
+ to = kstrdup(from, flag); | ||
... when != \(from = E1 \| to = E1 \) | ||
if (to==NULL || ...) S | ||
... when != \(from = E2 \| to = E2 \) | ||
- strcpy(to, from); | ||
|
||
@@ | ||
expression x,from,to; | ||
expression flag,E1,E2,E3; | ||
statement S; | ||
@@ | ||
|
||
- x = strlen(from) + 1; | ||
... when != \( x = E1 \| from = E1 \) | ||
- to = \(kmalloc\|kzalloc\)(x,flag); | ||
+ to = kstrdup(from, flag); | ||
... when != \(x = E2 \| from = E2 \| to = E2 \) | ||
if (to==NULL || ...) S | ||
... when != \(x = E3 \| from = E3 \| to = E3 \) | ||
- memcpy(to, from, x); |