Skip to content

Commit

Permalink
iio: light: lm3533-als: constify attribute_group structures
Browse files Browse the repository at this point in the history
Check for attribute_group structures that are only stored in the
event_attrs filed of iio_info structure. As the event_attrs field of
iio_info structures is constant, so these attribute_group structures can
also be declared constant. Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@Depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@Depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

As the attrs field of iio_info structures is also constant, so these
attribute_group structures can also be declared constant. Done manually.

File size before:
   text    data     bss     dec     hex filename
   5798    2376       0    8174    1fee drivers/iio/light/lm3533-als.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   5926	   2248	      0	   8174	   1fee	drivers/iio/light/lm3533-als.o

Signed-off-by: simran singhal <[email protected]>
Signed-off-by: Jonathan Cameron <[email protected]>
  • Loading branch information
simransinghal authored and jic23 committed Apr 2, 2017
1 parent 5738032 commit 98b6d2b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iio/light/lm3533-als.c
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ static struct attribute *lm3533_als_event_attributes[] = {
NULL
};

static struct attribute_group lm3533_als_event_attribute_group = {
static const struct attribute_group lm3533_als_event_attribute_group = {
.attrs = lm3533_als_event_attributes
};

Expand All @@ -714,7 +714,7 @@ static struct attribute *lm3533_als_attributes[] = {
NULL
};

static struct attribute_group lm3533_als_attribute_group = {
static const struct attribute_group lm3533_als_attribute_group = {
.attrs = lm3533_als_attributes
};

Expand Down

0 comments on commit 98b6d2b

Please sign in to comment.