Skip to content

Commit

Permalink
media: sunxi: sun8i-rotate.c: remove useless error message
Browse files Browse the repository at this point in the history
This fixes the following coccinelle report:

drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9:
line 751 is redundant because platform_get_irq() already prints an error

By removing the useless call to dev_err()

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
dwlsalmeida authored and mchehab committed Aug 29, 2020
1 parent 45f13a5 commit 97c6a99
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c
Original file line number Diff line number Diff line change
Expand Up @@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev)
dev->dev = &pdev->dev;

irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
dev_err(dev->dev, "Failed to get IRQ\n");

if (irq <= 0)
return irq;
}

ret = devm_request_irq(dev->dev, irq, rotate_irq,
0, dev_name(dev->dev), dev);
Expand Down

0 comments on commit 97c6a99

Please sign in to comment.