Skip to content

Commit

Permalink
lib: move kasprintf to a separate file
Browse files Browse the repository at this point in the history
kasprintf pulls in kmalloc which proved to be fatal for at least
bootimage target on alpha.
Move it to a separate file so only users of kasprintf are exposed
to the dependency on kmalloc.

Signed-off-by: Sam Ravnborg <[email protected]>
Cc: Jeremy Fitzhardinge <[email protected]>
Cc: Meelis Roos <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Ivan Kokshaysky <[email protected]>
Cc: Jay Estabrook <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
sravnborg authored and Linus Torvalds committed Jul 31, 2007
1 parent 9965a5d commit 96e3e18
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 36 deletions.
2 changes: 1 addition & 1 deletion lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Makefile for some libs needed in the kernel.
#

lib-y := ctype.o string.o vsprintf.o cmdline.o \
lib-y := ctype.o string.o vsprintf.o kasprintf.o cmdline.o \
rbtree.o radix-tree.o dump_stack.o \
idr.o int_sqrt.o bitmap.o extable.o prio_tree.o \
sha1.o irq_regs.o reciprocal_div.o argv_split.o
Expand Down
44 changes: 44 additions & 0 deletions lib/kasprintf.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* linux/lib/kasprintf.c
*
* Copyright (C) 1991, 1992 Linus Torvalds
*/

#include <stdarg.h>
#include <linux/module.h>
#include <linux/types.h>
#include <linux/string.h>

/* Simplified asprintf. */
char *kvasprintf(gfp_t gfp, const char *fmt, va_list ap)
{
unsigned int len;
char *p;
va_list aq;

va_copy(aq, ap);
len = vsnprintf(NULL, 0, fmt, aq);
va_end(aq);

p = kmalloc(len+1, gfp);
if (!p)
return NULL;

vsnprintf(p, len+1, fmt, ap);

return p;
}
EXPORT_SYMBOL(kvasprintf);

char *kasprintf(gfp_t gfp, const char *fmt, ...)
{
va_list ap;
char *p;

va_start(ap, fmt);
p = kvasprintf(gfp, fmt, ap);
va_end(ap);

return p;
}
EXPORT_SYMBOL(kasprintf);
35 changes: 0 additions & 35 deletions lib/vsprintf.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,38 +978,3 @@ int sscanf(const char * buf, const char * fmt, ...)
}

EXPORT_SYMBOL(sscanf);


/* Simplified asprintf. */
char *kvasprintf(gfp_t gfp, const char *fmt, va_list ap)
{
unsigned int len;
char *p;
va_list aq;

va_copy(aq, ap);
len = vsnprintf(NULL, 0, fmt, aq);
va_end(aq);

p = kmalloc(len+1, gfp);
if (!p)
return NULL;

vsnprintf(p, len+1, fmt, ap);

return p;
}
EXPORT_SYMBOL(kvasprintf);

char *kasprintf(gfp_t gfp, const char *fmt, ...)
{
va_list ap;
char *p;

va_start(ap, fmt);
p = kvasprintf(gfp, fmt, ap);
va_end(ap);

return p;
}
EXPORT_SYMBOL(kasprintf);

0 comments on commit 96e3e18

Please sign in to comment.