jfs: compare old and new mode before setting update_mode flag

If new mode is the same as old mode we don't have to reset inode mode in the rest of the code, so compare old and new mode before setting update_mode flag. Signed-off-by: Chengguang Xu <[email protected]> Signed-off-by: Dave Kleikamp <[email protected]>
mrcsosa · Jan 10, 2019 · 7ca5e8f · 7ca5e8f
1 parent 3a9a12f
commit 7ca5e8f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
@@ -117,7 +117,8 @@ int jfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
 		rc = posix_acl_update_mode(inode, &mode, &acl);
 		if (rc)
 			goto end_tx;
-		update_mode = 1;
+		if (mode != inode->i_mode)
+			update_mode = 1;
 	}
 	rc = __jfs_set_acl(tid, inode, type, acl);
 	if (!rc) {