[PATCH] sys_ioprio_set: minor do_each_thread+break fix

From include/linux/sched.h: * Careful: do_each_thread/while_each_thread is a double loop so * 'break' will not work as expected - use goto instead. */ Signed-off-by: Oleg Nesterov <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
mrcsosa · Aug 21, 2006 · 78bd4d4 · 78bd4d4
1 parent ef7d1b2
commit 78bd4d4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/fs/ioprio.c b/fs/ioprio.c
@@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which, int who, int ioprio)
 					continue;
 				ret = set_task_ioprio(p, ioprio);
 				if (ret)
-					break;
+					goto free_uid;
 			} while_each_thread(g, p);
-
+free_uid:
 			if (who)
 				free_uid(user);
 			break;