Skip to content

Commit

Permalink
RAS/CEC: Use the right length for "cec_disable"
Browse files Browse the repository at this point in the history
parse_cec_param() compares a string with "cec_disable" using only 7
characters of the 11-character-long string.

The proper solution for this would be:

#define CEC_DISABLE 	"cec_disable"

	strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE))

but when comparing a string against a string constant strncmp() has no
advantage over strcmp() because the comparison is guaranteed to be bound by
the string constant. So just replace str strncmp() with strcmp().

[ tglx: Made it use strcmp and updated the changelog ]

Fixes: 011d826 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Nicolas Iooss <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
  • Loading branch information
fishilico authored and KAGA-KOKO committed Oct 5, 2017
1 parent d81fa66 commit 69a3300
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ras/cec.c
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)
if (*str == '=')
str++;

if (!strncmp(str, "cec_disable", 7))
if (!strcmp(str, "cec_disable"))
ce_arr.disabled = 1;
else
return 0;
Expand Down

0 comments on commit 69a3300

Please sign in to comment.