Skip to content

Commit

Permalink
[SCSI] qla2xxx: Use midlayer's int_to_scsilun() function.
Browse files Browse the repository at this point in the history
While populating command type 6 and 7 IOCBs.

Signed-off-by: Andrew Vasquez <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
avasquez01 authored and James Bottomley committed Oct 28, 2005
1 parent 4fdfefe commit 661c3f6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/scsi/qla2xxx/qla_fw.h
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ struct cmd_type_6 {

uint16_t fcp_rsp_dsd_len; /* FCP_RSP DSD length. */

uint8_t lun[8]; /* FCP LUN (BE). */
struct scsi_lun lun; /* FCP LUN (BE). */

uint16_t control_flags; /* Control flags. */
#define CF_DATA_SEG_DESCR_ENABLE BIT_2
Expand Down Expand Up @@ -432,7 +432,7 @@ struct cmd_type_7 {
uint16_t dseg_count; /* Data segment count. */
uint16_t reserved_1;

uint8_t lun[8]; /* FCP LUN (BE). */
struct scsi_lun lun; /* FCP LUN (BE). */

uint16_t task_mgmt_flags; /* Task management flags. */
#define TMF_CLEAR_ACA BIT_14
Expand Down
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_iocb.c
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,7 @@ qla24xx_start_scsi(srb_t *sp)
cmd_pkt->port_id[1] = sp->fcport->d_id.b.area;
cmd_pkt->port_id[2] = sp->fcport->d_id.b.domain;

cmd_pkt->lun[1] = LSB(sp->cmd->device->lun);
cmd_pkt->lun[2] = MSB(sp->cmd->device->lun);
int_to_scsilun(sp->cmd->device->lun, &cmd_pkt->lun);

/* Update tagged queuing modifier -- default is TSK_SIMPLE (0). */
if (scsi_populate_tag_msg(cmd, tag)) {
Expand Down

0 comments on commit 661c3f6

Please sign in to comment.