Skip to content

Commit

Permalink
ieee1394: lock smaller region by host_num_alloc mutex
Browse files Browse the repository at this point in the history
We need the mutex only around the iteration over existing hosts.

Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
Stefan Richter committed Dec 7, 2006
1 parent b63d4fe commit 5c37dcb
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/ieee1394/hosts.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,9 @@ struct hpsb_host *hpsb_alloc_host(struct hpsb_host_driver *drv, size_t extra,
h->speed_map = (u8 *)(h->csr.speed_map + 2);

mutex_lock(&host_num_alloc);

while (nodemgr_for_each_host(&hostnum, alloc_hostnum_cb))
hostnum++;

mutex_unlock(&host_num_alloc);
h->id = hostnum;

memcpy(&h->device, &nodemgr_dev_template_host, sizeof(h->device));
Expand All @@ -175,8 +174,6 @@ struct hpsb_host *hpsb_alloc_host(struct hpsb_host_driver *drv, size_t extra,
class_device_register(&h->class_dev);
get_device(&h->device);

mutex_unlock(&host_num_alloc);

return h;
}

Expand Down

0 comments on commit 5c37dcb

Please sign in to comment.