Skip to content

Commit

Permalink
initmpfs: move bdi setup from init_rootfs to init_ramfs
Browse files Browse the repository at this point in the history
Even though ramfs hasn't got a backing device, commit e0bf68d ("mm:
bdi init hooks") added one anyway, and put the initialization in
init_rootfs() since that's the first user, leaving it out of init_ramfs()
to avoid duplication.

But initmpfs uses init_tmpfs() instead, so move the init into the
filesystem's init function, add a "once" guard to prevent duplicate
initialization, and call the filesystem init from rootfs init.

This goes part of the way to allowing ramfs to be built as a module.

[[email protected]; using bit 1 was odd]
Signed-off-by: Rob Landley <[email protected]>
Cc: Jeff Layton <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Stephen Warren <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Jim Cromie <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: Alexander Viro <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
landley authored and torvalds committed Sep 11, 2013
1 parent 137fdcc commit 4bbee76
Showing 1 changed file with 19 additions and 6 deletions.
25 changes: 19 additions & 6 deletions fs/ramfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ static struct dentry *rootfs_mount(struct file_system_type *fs_type,
{
static unsigned long once;

if (test_and_set_bit(1, &once))
if (test_and_set_bit(0, &once))
return ERR_PTR(-ENODEV);

return mount_nodev(fs_type, flags, data, ramfs_fill_super);
Expand All @@ -275,21 +275,34 @@ static struct file_system_type rootfs_fs_type = {

static int __init init_ramfs_fs(void)
{
return register_filesystem(&ramfs_fs_type);
static unsigned long once;
int err;

if (test_and_set_bit(0, &once))
return 0;

err = bdi_init(&ramfs_backing_dev_info);
if (err)
return err;

err = register_filesystem(&ramfs_fs_type);
if (err)
bdi_destroy(&ramfs_backing_dev_info);

return err;
}
module_init(init_ramfs_fs)

int __init init_rootfs(void)
{
int err;
int err = register_filesystem(&rootfs_fs_type);

err = bdi_init(&ramfs_backing_dev_info);
if (err)
return err;

err = register_filesystem(&rootfs_fs_type);
err = init_ramfs_fs();
if (err)
bdi_destroy(&ramfs_backing_dev_info);
unregister_filesystem(&rootfs_fs_type);

return err;
}

0 comments on commit 4bbee76

Please sign in to comment.