Skip to content

Commit

Permalink
[SCSI] kmalloc argument switcheroo in recent 53c700 change.
Browse files Browse the repository at this point in the history
On Wed, Jun 21, 2006 at 07:00:34PM +0000, Linux Kernel wrote:
 > commit 67d59df
 > tree ae85703651d81740f4a6cd398f9dd4d6aabe6a2f
 > parent 6db874f
 > author James Bottomley <[email protected]> Wed, 14 Jun 2006 07:31:19 -0500
 > committer James Bottomley <[email protected]> Tue, 20 Jun 2006 05:34:01 -0500
 >
 > [SCSI] 53c700: remove reliance on deprecated cmnd fields
 >  ...
 >
 > +	SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
 > +
 > +	if (!SDp->hostdata)
 > +		return -ENOMEM;

"I'll take reversed arguments for $100 please Alex".

Signed-off-by: Dave Jones <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Dave Jones authored and James Bottomley committed Jun 26, 2006
1 parent fcc18e8 commit 4311fa6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/53c700.c
Original file line number Diff line number Diff line change
Expand Up @@ -2044,7 +2044,7 @@ NCR_700_slave_configure(struct scsi_device *SDp)
struct NCR_700_Host_Parameters *hostdata =
(struct NCR_700_Host_Parameters *)SDp->host->hostdata[0];

SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
SDp->hostdata = kmalloc(sizeof(struct NCR_700_sense), GFP_KERNEL);

if (!SDp->hostdata)
return -ENOMEM;
Expand Down

0 comments on commit 4311fa6

Please sign in to comment.