Skip to content

Commit

Permalink
fsnotify: constify 'data' passed to ->handle_event()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Dec 5, 2016
1 parent 640eb7e commit 3cd5eca
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion fs/notify/dnotify/dnotify.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ static int dnotify_handle_event(struct fsnotify_group *group,
struct inode *inode,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie)
{
struct dnotify_mark *dn_mark;
Expand Down
8 changes: 4 additions & 4 deletions fs/notify/fanotify/fanotify.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ static int fanotify_get_response(struct fsnotify_group *group,
static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmnt_mark,
u32 event_mask,
void *data, int data_type)
const void *data, int data_type)
{
__u32 marks_mask, marks_ignored_mask;
struct path *path = data;
const struct path *path = data;

pr_debug("%s: inode_mark=%p vfsmnt_mark=%p mask=%x data=%p"
" data_type=%d\n", __func__, inode_mark, vfsmnt_mark,
Expand Down Expand Up @@ -140,7 +140,7 @@ static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark,
}

struct fanotify_event_info *fanotify_alloc_event(struct inode *inode, u32 mask,
struct path *path)
const struct path *path)
{
struct fanotify_event_info *event;

Expand Down Expand Up @@ -177,7 +177,7 @@ static int fanotify_handle_event(struct fsnotify_group *group,
struct inode *inode,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *fanotify_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie)
{
int ret = 0;
Expand Down
2 changes: 1 addition & 1 deletion fs/notify/fanotify/fanotify.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ static inline struct fanotify_event_info *FANOTIFY_E(struct fsnotify_event *fse)
}

struct fanotify_event_info *fanotify_alloc_event(struct inode *inode, u32 mask,
struct path *path);
const struct path *path);
2 changes: 1 addition & 1 deletion fs/notify/inotify/inotify.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ extern int inotify_handle_event(struct fsnotify_group *group,
struct inode *inode,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie);

extern const struct fsnotify_ops inotify_fsnotify_ops;
4 changes: 2 additions & 2 deletions fs/notify/inotify/inotify_fsnotify.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ int inotify_handle_event(struct fsnotify_group *group,
struct inode *inode,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie)
{
struct inotify_inode_mark *i_mark;
Expand All @@ -80,7 +80,7 @@ int inotify_handle_event(struct fsnotify_group *group,

if ((inode_mark->mask & FS_EXCL_UNLINK) &&
(data_type == FSNOTIFY_EVENT_PATH)) {
struct path *path = data;
const struct path *path = data;

if (d_unlinked(path->dentry))
return 0;
Expand Down
2 changes: 1 addition & 1 deletion include/linux/fsnotify_backend.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ struct fsnotify_ops {
struct inode *inode,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie);
void (*free_group_priv)(struct fsnotify_group *group);
void (*freeing_mark)(struct fsnotify_mark *mark, struct fsnotify_group *group);
Expand Down
10 changes: 5 additions & 5 deletions kernel/audit_fsnotify.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ int audit_mark_compare(struct audit_fsnotify_mark *mark, unsigned long ino, dev_
}

static void audit_update_mark(struct audit_fsnotify_mark *audit_mark,
struct inode *inode)
const struct inode *inode)
{
audit_mark->dev = inode ? inode->i_sb->s_dev : AUDIT_DEV_UNSET;
audit_mark->ino = inode ? inode->i_ino : AUDIT_INO_UNSET;
Expand Down Expand Up @@ -168,22 +168,22 @@ static int audit_mark_handle_event(struct fsnotify_group *group,
struct inode *to_tell,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *dname, u32 cookie)
{
struct audit_fsnotify_mark *audit_mark;
struct inode *inode = NULL;
const struct inode *inode = NULL;

audit_mark = container_of(inode_mark, struct audit_fsnotify_mark, mark);

BUG_ON(group != audit_fsnotify_group);

switch (data_type) {
case (FSNOTIFY_EVENT_PATH):
inode = ((struct path *)data)->dentry->d_inode;
inode = ((const struct path *)data)->dentry->d_inode;
break;
case (FSNOTIFY_EVENT_INODE):
inode = (struct inode *)data;
inode = (const struct inode *)data;
break;
default:
BUG();
Expand Down
2 changes: 1 addition & 1 deletion kernel/audit_tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ static int audit_tree_handle_event(struct fsnotify_group *group,
struct inode *to_tell,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *file_name, u32 cookie)
{
return 0;
Expand Down
8 changes: 4 additions & 4 deletions kernel/audit_watch.c
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,10 @@ static int audit_watch_handle_event(struct fsnotify_group *group,
struct inode *to_tell,
struct fsnotify_mark *inode_mark,
struct fsnotify_mark *vfsmount_mark,
u32 mask, void *data, int data_type,
u32 mask, const void *data, int data_type,
const unsigned char *dname, u32 cookie)
{
struct inode *inode;
const struct inode *inode;
struct audit_parent *parent;

parent = container_of(inode_mark, struct audit_parent, mark);
Expand All @@ -484,10 +484,10 @@ static int audit_watch_handle_event(struct fsnotify_group *group,

switch (data_type) {
case (FSNOTIFY_EVENT_PATH):
inode = d_backing_inode(((struct path *)data)->dentry);
inode = d_backing_inode(((const struct path *)data)->dentry);
break;
case (FSNOTIFY_EVENT_INODE):
inode = (struct inode *)data;
inode = (const struct inode *)data;
break;
default:
BUG();
Expand Down

0 comments on commit 3cd5eca

Please sign in to comment.