Skip to content

Commit

Permalink
get rid of pt_regs argument of search_binary_handler()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Nov 29, 2012
1 parent 835ab32 commit 3c456bf
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion arch/alpha/kernel/binfmt_loader.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ static int load_binary(struct linux_binprm *bprm, struct pt_regs *regs)
retval = prepare_binprm(bprm);
if (retval < 0)
return retval;
return search_binary_handler(bprm,regs);
return search_binary_handler(bprm);
}

static struct linux_binfmt loader_format = {
Expand Down
2 changes: 1 addition & 1 deletion fs/binfmt_em86.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static int load_em86(struct linux_binprm *bprm,struct pt_regs *regs)
if (retval < 0)
return retval;

return search_binary_handler(bprm, regs);
return search_binary_handler(bprm);
}

static struct linux_binfmt em86_format = {
Expand Down
2 changes: 1 addition & 1 deletion fs/binfmt_misc.c
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ static int load_misc_binary(struct linux_binprm *bprm, struct pt_regs *regs)

bprm->recursion_depth++;

retval = search_binary_handler (bprm, regs);
retval = search_binary_handler(bprm);
if (retval < 0)
goto _error;

Expand Down
2 changes: 1 addition & 1 deletion fs/binfmt_script.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ static int load_script(struct linux_binprm *bprm,struct pt_regs *regs)
retval = prepare_binprm(bprm);
if (retval < 0)
return retval;
return search_binary_handler(bprm,regs);
return search_binary_handler(bprm);
}

static struct linux_binfmt script_format = {
Expand Down
7 changes: 3 additions & 4 deletions fs/exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1349,7 +1349,7 @@ EXPORT_SYMBOL(remove_arg_zero);
/*
* cycle the list of binary formats handler, until one recognizes the image
*/
int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs)
int search_binary_handler(struct linux_binprm *bprm)
{
unsigned int depth = bprm->recursion_depth;
int try,retval;
Expand Down Expand Up @@ -1380,7 +1380,7 @@ int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs)
if (!try_module_get(fmt->module))
continue;
read_unlock(&binfmt_lock);
retval = fn(bprm, regs);
retval = fn(bprm, current_pt_regs());
/*
* Restore the depth counter to its starting value
* in this call, so we don't have to rely on every
Expand Down Expand Up @@ -1447,7 +1447,6 @@ static int do_execve_common(const char *filename,
bool clear_in_exec;
int retval;
const struct cred *cred = current_cred();
struct pt_regs *regs = current_pt_regs();

/*
* We move the actual failure in case of RLIMIT_NPROC excess from
Expand Down Expand Up @@ -1524,7 +1523,7 @@ static int do_execve_common(const char *filename,
if (retval < 0)
goto out;

retval = search_binary_handler(bprm,regs);
retval = search_binary_handler(bprm);
if (retval < 0)
goto out;

Expand Down
2 changes: 1 addition & 1 deletion include/linux/binfmts.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ extern void unregister_binfmt(struct linux_binfmt *);

extern int prepare_binprm(struct linux_binprm *);
extern int __must_check remove_arg_zero(struct linux_binprm *);
extern int search_binary_handler(struct linux_binprm *, struct pt_regs *);
extern int search_binary_handler(struct linux_binprm *);
extern int flush_old_exec(struct linux_binprm * bprm);
extern void setup_new_exec(struct linux_binprm * bprm);
extern void would_dump(struct linux_binprm *, struct file *);
Expand Down

0 comments on commit 3c456bf

Please sign in to comment.