block: add WARN_ON if bdi register fail

device_add_disk need do more safety error handle, so this patch just add WARN_ON. Reviewed-by: Jan Kara <[email protected]> Signed-off-by: weiping zhang <[email protected]> Adapted for current series by me. Signed-off-by: Jens Axboe <[email protected]>
mrcsosa · Nov 19, 2017 · 3a92168 · 3a92168
1 parent a0747a8
commit 3a92168
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/block/genhd.c b/block/genhd.c
@@ -671,10 +671,13 @@ void device_add_disk(struct device *parent, struct gendisk *disk)
 		disk->flags |= GENHD_FL_SUPPRESS_PARTITION_INFO;
 		disk->flags |= GENHD_FL_NO_PART_SCAN;
 	} else {
+		int ret;
+
 		/* Register BDI before referencing it from bdev */
 		disk_to_dev(disk)->devt = devt;
-		bdi_register_owner(disk->queue->backing_dev_info,
-				disk_to_dev(disk));
+		ret = bdi_register_owner(disk->queue->backing_dev_info,
+						disk_to_dev(disk));
+		WARN_ON(ret);
 		blk_register_region(disk_devt(disk), disk->minors, NULL,
 				    exact_match, exact_lock, disk);
 	}