Skip to content

Commit

Permalink
mm: migrate: remove unused mode argument
Browse files Browse the repository at this point in the history
migrate_page_move_mapping() doesn't use the mode argument.  Remove it
and update callers accordingly.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Keith Busch <[email protected]>
Reviewed-by: Zi Yan <[email protected]>
Cc: Mel Gorman <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Keith Busch authored and torvalds committed Jul 19, 2019
1 parent 9a84503 commit 3710969
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ static int aio_migratepage(struct address_space *mapping, struct page *new,
BUG_ON(PageWriteback(old));
get_page(new);

rc = migrate_page_move_mapping(mapping, new, old, mode, 1);
rc = migrate_page_move_mapping(mapping, new, old, 1);
if (rc != MIGRATEPAGE_SUCCESS) {
put_page(new);
goto out_unlock;
Expand Down
2 changes: 1 addition & 1 deletion fs/f2fs/data.c
Original file line number Diff line number Diff line change
Expand Up @@ -2919,7 +2919,7 @@ int f2fs_migrate_page(struct address_space *mapping,
/* one extra reference was held for atomic_write page */
extra_count = atomic_written ? 1 : 0;
rc = migrate_page_move_mapping(mapping, newpage,
page, mode, extra_count);
page, extra_count);
if (rc != MIGRATEPAGE_SUCCESS) {
if (atomic_written)
mutex_unlock(&fi->inmem_lock);
Expand Down
2 changes: 1 addition & 1 deletion fs/iomap.c
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ iomap_migrate_page(struct address_space *mapping, struct page *newpage,
{
int ret;

ret = migrate_page_move_mapping(mapping, newpage, page, mode, 0);
ret = migrate_page_move_mapping(mapping, newpage, page, 0);
if (ret != MIGRATEPAGE_SUCCESS)
return ret;

Expand Down
2 changes: 1 addition & 1 deletion fs/ubifs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ static int ubifs_migrate_page(struct address_space *mapping,
{
int rc;

rc = migrate_page_move_mapping(mapping, newpage, page, mode, 0);
rc = migrate_page_move_mapping(mapping, newpage, page, 0);
if (rc != MIGRATEPAGE_SUCCESS)
return rc;

Expand Down
3 changes: 1 addition & 2 deletions include/linux/migrate.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ extern void migrate_page_copy(struct page *newpage, struct page *page);
extern int migrate_huge_page_move_mapping(struct address_space *mapping,
struct page *newpage, struct page *page);
extern int migrate_page_move_mapping(struct address_space *mapping,
struct page *newpage, struct page *page, enum migrate_mode mode,
int extra_count);
struct page *newpage, struct page *page, int extra_count);
#else

static inline void putback_movable_pages(struct list_head *l) {}
Expand Down
7 changes: 3 additions & 4 deletions mm/migrate.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,7 @@ static int expected_page_refs(struct address_space *mapping, struct page *page)
* 3 for pages with a mapping and PagePrivate/PagePrivate2 set.
*/
int migrate_page_move_mapping(struct address_space *mapping,
struct page *newpage, struct page *page, enum migrate_mode mode,
int extra_count)
struct page *newpage, struct page *page, int extra_count)
{
XA_STATE(xas, &mapping->i_pages, page_index(page));
struct zone *oldzone, *newzone;
Expand Down Expand Up @@ -681,7 +680,7 @@ int migrate_page(struct address_space *mapping,

BUG_ON(PageWriteback(page)); /* Writeback must be complete */

rc = migrate_page_move_mapping(mapping, newpage, page, mode, 0);
rc = migrate_page_move_mapping(mapping, newpage, page, 0);

if (rc != MIGRATEPAGE_SUCCESS)
return rc;
Expand Down Expand Up @@ -780,7 +779,7 @@ static int __buffer_migrate_page(struct address_space *mapping,
}
}

rc = migrate_page_move_mapping(mapping, newpage, page, mode, 0);
rc = migrate_page_move_mapping(mapping, newpage, page, 0);
if (rc != MIGRATEPAGE_SUCCESS)
goto unlock_buffers;

Expand Down

0 comments on commit 3710969

Please sign in to comment.