Skip to content

Commit

Permalink
mn10300: switch to GENERIC_PCI_IOMAP
Browse files Browse the repository at this point in the history
The pci_iomap variant that arch/mn10300/unit-asb2305/pci-iomap.c
uses differs from the generic one in that it does
not use ioremap_nocache for PCI addresses.
However, it turns out that PCI addresses are
automatically noncached, so switching to ioremap_nocache
and to the generic implementation is safe.

Signed-off-by: Michael S. Tsirkin <[email protected]>
  • Loading branch information
mstsirkin committed Dec 4, 2011
1 parent 2ebf5d0 commit 34f1bde
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 33 deletions.
1 change: 1 addition & 0 deletions arch/mn10300/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ config PCI
bool "Use PCI"
depends on MN10300_UNIT_ASB2305
default y
select GENERIC_PCI_IOMAP
help
Some systems (such as the ASB2305) have PCI onboard. If you have one
of these boards and you wish to use the PCI facilities, say Y here.
Expand Down
1 change: 0 additions & 1 deletion arch/mn10300/include/asm/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ static inline void outsl(unsigned long addr, const void *buffer, int count)

/* Create a virtual mapping cookie for a PCI BAR (memory or IO) */
struct pci_dev;
extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
static inline void pci_iounmap(struct pci_dev *dev, void __iomem *p)
{
}
Expand Down
2 changes: 1 addition & 1 deletion arch/mn10300/unit-asb2305/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
###############################################################################
obj-y := unit-init.o leds.o

obj-$(CONFIG_PCI) += pci.o pci-asb2305.o pci-irq.o pci-iomap.o
obj-$(CONFIG_PCI) += pci.o pci-asb2305.o pci-irq.o
31 changes: 0 additions & 31 deletions arch/mn10300/unit-asb2305/pci-iomap.c

This file was deleted.

0 comments on commit 34f1bde

Please sign in to comment.