Skip to content

Commit

Permalink
Drivers: clean up direct setting of the name of a kset
Browse files Browse the repository at this point in the history
A kset should not have its name set directly, so dynamically set the
name at runtime.

This is needed to remove the static array in the kobject structure which
will be changed in a future patch.

Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Oct 12, 2007
1 parent 7e7654a commit 34980ca
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
3 changes: 2 additions & 1 deletion drivers/edac/edac_mc_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ static struct kobj_type ktype_mc_set_attribs = {
* /sys/devices/system/edac/mc
*/
static struct kset mc_kset = {
.kobj = {.name = "mc", .ktype = &ktype_mc_set_attribs },
.kobj = {.ktype = &ktype_mc_set_attribs },
.ktype = &ktype_mci,
};

Expand Down Expand Up @@ -1010,6 +1010,7 @@ int edac_sysfs_setup_mc_kset(void)
}

/* Init the MC's kobject */
kobject_set_name(&mc_kset.kobj, "mc");
mc_kset.kobj.parent = &edac_class->kset.kobj;

/* register the mc_kset */
Expand Down
6 changes: 3 additions & 3 deletions drivers/pci/hotplug/rpadlpar_sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,17 @@ struct kobj_type ktype_dlpar_io = {
};

struct kset dlpar_io_kset = {
.kobj = {.name = DLPAR_KOBJ_NAME,
.ktype = &ktype_dlpar_io,
.kobj = {.ktype = &ktype_dlpar_io,
.parent = &pci_hotplug_slots_subsys.kobj},
.ktype = &ktype_dlpar_io,
};

int dlpar_sysfs_init(void)
{
kobject_set_name(&dlpar_io_kset.kobj, DLPAR_KOBJ_NAME);
if (kset_register(&dlpar_io_kset)) {
printk(KERN_ERR "rpadlpar_io: cannot register kset for %s\n",
dlpar_io_kset.kobj.name);
kobject_name(&dlpar_io_kset.kobj));
return -EINVAL;
}

Expand Down
2 changes: 1 addition & 1 deletion fs/dlm/lockspace.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ static struct kobj_type dlm_ktype = {
};

static struct kset dlm_kset = {
.kobj = {.name = "dlm",},
.ktype = &dlm_ktype,
};

Expand Down Expand Up @@ -228,6 +227,7 @@ int dlm_lockspace_init(void)
INIT_LIST_HEAD(&lslist);
spin_lock_init(&lslist_lock);

kobject_set_name(&dlm_kset.kobj, "dlm");
kobj_set_kset_s(&dlm_kset, kernel_subsys);
error = kset_register(&dlm_kset);
if (error)
Expand Down
2 changes: 1 addition & 1 deletion fs/gfs2/locking/dlm/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ static struct kobj_type gdlm_ktype = {
};

static struct kset gdlm_kset = {
.kobj = {.name = "lock_dlm",},
.ktype = &gdlm_ktype,
};

Expand Down Expand Up @@ -224,6 +223,7 @@ int gdlm_sysfs_init(void)
{
int error;

kobject_set_name(&gdlm_kset.kobj, "lock_dlm");
kobj_set_kset_s(&gdlm_kset, kernel_subsys);
error = kset_register(&gdlm_kset);
if (error)
Expand Down
2 changes: 1 addition & 1 deletion fs/gfs2/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ static struct kobj_type gfs2_ktype = {
};

static struct kset gfs2_kset = {
.kobj = {.name = "gfs2"},
.ktype = &gfs2_ktype,
};

Expand Down Expand Up @@ -553,6 +552,7 @@ int gfs2_sys_init(void)
{
gfs2_sys_margs = NULL;
spin_lock_init(&gfs2_sys_margs_lock);
kobject_set_name(&gfs2_kset.kobj, "gfs2");
kobj_set_kset_s(&gfs2_kset, fs_subsys);
return kset_register(&gfs2_kset);
}
Expand Down
3 changes: 2 additions & 1 deletion fs/ocfs2/cluster/masklog.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ static struct kobj_type mlog_ktype = {
};

static struct kset mlog_kset = {
.kobj = {.name = "logmask", .ktype = &mlog_ktype},
.kobj = {.ktype = &mlog_ktype},
};

int mlog_sys_init(struct kset *o2cb_subsys)
Expand All @@ -156,6 +156,7 @@ int mlog_sys_init(struct kset *o2cb_subsys)
}
mlog_attr_ptrs[i] = NULL;

kobject_set_name(&mlog_kset.kobj, "logmask");
kobj_set_kset_s(&mlog_kset, *o2cb_subsys);
return kset_register(&mlog_kset);
}
Expand Down

0 comments on commit 34980ca

Please sign in to comment.