Skip to content

Commit

Permalink
ASoC: sh: Replace 'select' DMADEVICES 'with depends on'
Browse files Browse the repository at this point in the history
Enabling a whole subsystem from a single driver 'select' is frowned
upon and won't be accepted in new drivers, that need to use 'depends on'
instead. Existing selection of DMADEVICES will then cause circular
dependencies. Replace them with a dependency.

Signed-off-by: Laurent Pinchart <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
pinchartl authored and broonie committed Jul 31, 2020
1 parent 14e5ad7 commit 2dbf11e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/sh/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ config SND_SOC_SH4_FSI
config SND_SOC_SH4_SIU
tristate
depends on ARCH_SHMOBILE && HAVE_CLK
depends on DMADEVICES
select DMA_ENGINE
select DMADEVICES
select SH_DMAE
select FW_LOADER

Expand Down

0 comments on commit 2dbf11e

Please sign in to comment.