kobject: Replace ALL occurrences of '/' with '!' instead of only the …

…first one. A recent patch from Kay Sievers <[email protected]> replaced the first occurrence of '/' with '!' as needed for block devices. Now do some cheap defensive coding and replace all of them to avoid future issues in this area. Signed-off-by: Ingo Oeser <[email protected]> Cc: Kay Sievers <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
mrcsosa · Aug 21, 2008 · 25fdeb3 · 25fdeb3
1 parent 6a55617
commit 25fdeb3
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/kobject.c b/lib/kobject.c
@@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		return -ENOMEM;
 
 	/* ewww... some of these buggers have '/' in the name ... */
-	s = strchr(kobj->name, '/');
-	if (s)
+	while ((s = strchr(kobj->name, '/')))
 		s[0] = '!';
 
 	kfree(old_name);