Skip to content

Commit

Permalink
mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'
Browse files Browse the repository at this point in the history
A semaphore is acquired before this check, so we must release it before
leaving.

Link: http://lkml.kernel.org/r/[email protected]
Fixes: b7f0554 ("mm: fail get_vaddr_frames() for filesystem-dax mappings")
Signed-off-by: Christophe JAILLET <[email protected]>
Acked-by: Michal Hocko <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: David Sterba <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
tititiou36 authored and torvalds committed Dec 15, 2017
1 parent 0b265c3 commit 1f704fd
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions mm/frame_vector.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames,
* get_user_pages_longterm() and disallow it for filesystem-dax
* mappings.
*/
if (vma_is_fsdax(vma))
return -EOPNOTSUPP;
if (vma_is_fsdax(vma)) {
ret = -EOPNOTSUPP;
goto out;
}

if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) {
vec->got_ref = true;
Expand Down

0 comments on commit 1f704fd

Please sign in to comment.