Skip to content

Commit

Permalink
genirq: Remove __do_IRQ
Browse files Browse the repository at this point in the history
All architectures are finally converted. Remove the cruft.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Mike Frysinger <[email protected]>
Cc: David Howells <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Greg Ungerer <[email protected]>
Cc: Michal Simek <[email protected]>
Acked-by: David Howells <[email protected]>
Cc: Kyle McMartin <[email protected]>
Acked-by: Benjamin Herrenschmidt <[email protected]>
Cc: Chen Liqin <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Chris Metcalf <[email protected]>
Cc: Jeff Dike <[email protected]>
  • Loading branch information
KAGA-KOKO committed Jan 21, 2011
1 parent 0e155b2 commit 1c77ff2
Show file tree
Hide file tree
Showing 18 changed files with 0 additions and 183 deletions.
8 changes: 0 additions & 8 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,6 @@ Who: Dave Jones <[email protected]>, Matthew Garrett <[email protected]>

-----------------------------

What: __do_IRQ all in one fits nothing interrupt handler
When: 2.6.32
Why: __do_IRQ was kept for easy migration to the type flow handlers.
More than two years of migration time is enough.
Who: Thomas Gleixner <[email protected]>

-----------------------------

What: fakephp and associated sysfs files in /sys/bus/pci/slots/
When: 2011
Why: In 2.6.27, the semantics of /sys/bus/pci/slots was redefined to
Expand Down
3 changes: 0 additions & 3 deletions arch/alpha/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ config GENERIC_IOMAP
bool
default n

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_HARDIRQS
bool
default y
Expand Down
3 changes: 0 additions & 3 deletions arch/blackfin/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ config GENERIC_HARDIRQS
config GENERIC_IRQ_PROBE
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_GPIO
def_bool y

Expand Down
4 changes: 0 additions & 4 deletions arch/frv/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ config GENERIC_HARDIRQS
bool
default y

config GENERIC_HARDIRQS_NO__DO_IRQ
bool
default y

config TIME_LOW_RES
bool
default y
Expand Down
3 changes: 0 additions & 3 deletions arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -684,9 +684,6 @@ source "lib/Kconfig"
config GENERIC_HARDIRQS
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_IRQ_PROBE
bool
default y
Expand Down
4 changes: 0 additions & 4 deletions arch/m68knommu/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ config GENERIC_HARDIRQS
bool
default y

config GENERIC_HARDIRQS_NO__DO_IRQ
bool
default y

config GENERIC_CALIBRATE_DELAY
bool
default y
Expand Down
3 changes: 0 additions & 3 deletions arch/microblaze/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ config GENERIC_TIME_VSYSCALL
config GENERIC_CLOCKEVENTS
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_GPIO
def_bool y

Expand Down
3 changes: 0 additions & 3 deletions arch/mips/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,6 @@ config SCHED_OMIT_FRAME_POINTER
bool
default y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

#
# Select some configuration options automatically based on user selections.
#
Expand Down
3 changes: 0 additions & 3 deletions arch/mn10300/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ config RWSEM_GENERIC_SPINLOCK
config RWSEM_XCHGADD_ALGORITHM
bool

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_CALIBRATE_DELAY
def_bool y

Expand Down
4 changes: 0 additions & 4 deletions arch/parisc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ config PARISC
select HAVE_IRQ_WORK
select HAVE_PERF_EVENTS
select GENERIC_ATOMIC64 if !64BIT
select GENERIC_HARDIRQS_NO__DO_IRQ
help
The PA-RISC microprocessor is designed by Hewlett-Packard and used
in many of their workstations & servers (HP9000 700 and 800 series,
Expand Down Expand Up @@ -79,9 +78,6 @@ config IRQ_PER_CPU
bool
default y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

# unless you want to implement ACPI on PA-RISC ... ;-)
config PM
bool
Expand Down
4 changes: 0 additions & 4 deletions arch/powerpc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ config GENERIC_HARDIRQS
bool
default y

config GENERIC_HARDIRQS_NO__DO_IRQ
bool
default y

config HAVE_SETUP_PER_CPU_AREA
def_bool PPC64

Expand Down
3 changes: 0 additions & 3 deletions arch/score/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ config GENERIC_CLOCKEVENTS
config SCHED_NO_NO_OMIT_FRAME_POINTER
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_SYSCALL_TABLE
def_bool y

Expand Down
4 changes: 0 additions & 4 deletions arch/sparc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
config NEED_PER_CPU_PAGE_FIRST_CHUNK
def_bool y if SPARC64

config GENERIC_HARDIRQS_NO__DO_IRQ
bool
def_bool y if SPARC64

config MMU
bool
default y
Expand Down
3 changes: 0 additions & 3 deletions arch/tile/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ config GENERIC_CSUM
config GENERIC_HARDIRQS
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config GENERIC_IRQ_PROBE
def_bool y

Expand Down
3 changes: 0 additions & 3 deletions arch/um/Kconfig.um
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ config SMP

If you don't know what to do, say N.

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

config NR_CPUS
int "Maximum number of CPUs (2-32)"
range 2 32
Expand Down
14 changes: 0 additions & 14 deletions include/linux/irqdesc.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,6 @@ static inline struct irq_desc *move_irq_desc(struct irq_desc *desc, int node)
#define get_irq_desc_data(desc) ((desc)->irq_data.handler_data)
#define get_irq_desc_msi(desc) ((desc)->irq_data.msi_desc)

/*
* Monolithic do_IRQ implementation.
*/
#ifndef CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ
extern unsigned int __do_IRQ(unsigned int irq);
#endif

/*
* Architectures call this to let the generic IRQ layer
* handle an interrupt. If the descriptor is attached to an
Expand All @@ -115,14 +108,7 @@ extern unsigned int __do_IRQ(unsigned int irq);
*/
static inline void generic_handle_irq_desc(unsigned int irq, struct irq_desc *desc)
{
#ifdef CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ
desc->handle_irq(irq, desc);
#else
if (likely(desc->handle_irq))
desc->handle_irq(irq, desc);
else
__do_IRQ(irq);
#endif
}

static inline void generic_handle_irq(unsigned int irq)
Expand Down
3 changes: 0 additions & 3 deletions kernel/irq/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ menu "IRQ subsystem"
config GENERIC_HARDIRQS
def_bool y

config GENERIC_HARDIRQS_NO__DO_IRQ
def_bool y

# Select this to disable the deprecated stuff
config GENERIC_HARDIRQS_NO_DEPRECATED
def_bool n
Expand Down
111 changes: 0 additions & 111 deletions kernel/irq/handle.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,114 +118,3 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)

return retval;
}

#ifndef CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ

#ifdef CONFIG_ENABLE_WARN_DEPRECATED
# warning __do_IRQ is deprecated. Please convert to proper flow handlers
#endif

/**
* __do_IRQ - original all in one highlevel IRQ handler
* @irq: the interrupt number
*
* __do_IRQ handles all normal device IRQ's (the special
* SMP cross-CPU interrupts have their own specific
* handlers).
*
* This is the original x86 implementation which is used for every
* interrupt type.
*/
unsigned int __do_IRQ(unsigned int irq)
{
struct irq_desc *desc = irq_to_desc(irq);
struct irqaction *action;
unsigned int status;

kstat_incr_irqs_this_cpu(irq, desc);

if (CHECK_IRQ_PER_CPU(desc->status)) {
irqreturn_t action_ret;

/*
* No locking required for CPU-local interrupts:
*/
if (desc->irq_data.chip->ack)
desc->irq_data.chip->ack(irq);
if (likely(!(desc->status & IRQ_DISABLED))) {
action_ret = handle_IRQ_event(irq, desc->action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
}
desc->irq_data.chip->end(irq);
return 1;
}

raw_spin_lock(&desc->lock);
if (desc->irq_data.chip->ack)
desc->irq_data.chip->ack(irq);
/*
* REPLAY is when Linux resends an IRQ that was dropped earlier
* WAITING is used by probe to mark irqs that are being tested
*/
status = desc->status & ~(IRQ_REPLAY | IRQ_WAITING);
status |= IRQ_PENDING; /* we _want_ to handle it */

/*
* If the IRQ is disabled for whatever reason, we cannot
* use the action we have.
*/
action = NULL;
if (likely(!(status & (IRQ_DISABLED | IRQ_INPROGRESS)))) {
action = desc->action;
status &= ~IRQ_PENDING; /* we commit to handling */
status |= IRQ_INPROGRESS; /* we are handling it */
}
desc->status = status;

/*
* If there is no IRQ handler or it was disabled, exit early.
* Since we set PENDING, if another processor is handling
* a different instance of this same irq, the other processor
* will take care of it.
*/
if (unlikely(!action))
goto out;

/*
* Edge triggered interrupts need to remember
* pending events.
* This applies to any hw interrupts that allow a second
* instance of the same irq to arrive while we are in do_IRQ
* or in the handler. But the code here only handles the _second_
* instance of the irq, not the third or fourth. So it is mostly
* useful for irq hardware that does not mask cleanly in an
* SMP environment.
*/
for (;;) {
irqreturn_t action_ret;

raw_spin_unlock(&desc->lock);

action_ret = handle_IRQ_event(irq, action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);

raw_spin_lock(&desc->lock);
if (likely(!(desc->status & IRQ_PENDING)))
break;
desc->status &= ~IRQ_PENDING;
}
desc->status &= ~IRQ_INPROGRESS;

out:
/*
* The ->end() handler has to deal with interrupts which got
* disabled while the handler was running.
*/
desc->irq_data.chip->end(irq);
raw_spin_unlock(&desc->lock);

return 1;
}
#endif

0 comments on commit 1c77ff2

Please sign in to comment.