Skip to content

Commit

Permalink
tty: amba-pl011: Use 32-bit accesses for SBSA UART
Browse files Browse the repository at this point in the history
Version 2 of the Server Base System Architecture (SBSAv2) describes UART
hardware registers as 32 bits wide, giving no guidance on access sizes. The
SBSA UART driver previously assumed partial-length 16 and 8 bit accesses would
work. But the SBSAv2 UART hardware on the Qualcomm Technologies QDF2432 only
supports full-length 32 bit register accesses, so use those exclusively. This
is compatible with SBSAv3, which explicitly requires UART hardware support 32
(and 16 and sometimes 8) bit accesses.

Tested on Juno, Midway, QDF2432, Seattle, and X-Gene 1.

Tested-by: Mark Langsdorf <[email protected]>
Tested-by: Andre Przywara <[email protected]>
Acked-by: Andre Przywara <[email protected]>
Signed-off-by: Christopher Covington <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
covracer authored and gregkh committed Apr 30, 2016
1 parent 5be605a commit 1aabf52
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/tty/serial/amba-pl011.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ static struct vendor_data vendor_arm = {

static struct vendor_data vendor_sbsa = {
.reg_offset = pl011_std_offsets,
.access_32b = true,
.oversampling = false,
.dma_threshold = false,
.cts_event_workaround = false,
Expand Down

0 comments on commit 1aabf52

Please sign in to comment.