cifs: check kmalloc before use

The kmalloc was not being checked - if it fails issue a warning and return -ENOMEM to the caller. Signed-off-by: Nicholas Mc Guire <[email protected]> Fixes: b8da344 ("cifs: dynamic allocation of ntlmssp blob") Signed-off-by: Steve French <[email protected]> Reviewed-by: Pavel Shilovsky <[email protected]> cc: Stable <[email protected]>`
mrcsosa · Aug 23, 2018 · 126c97f · 126c97f
1 parent e6c47dd
commit 126c97f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
@@ -398,6 +398,12 @@ int build_ntlmssp_auth_blob(unsigned char **pbuffer,
 		goto setup_ntlmv2_ret;
 	}
 	*pbuffer = kmalloc(size_of_ntlmssp_blob(ses), GFP_KERNEL);
+	if (!*pbuffer) {
+		rc = -ENOMEM;
+		cifs_dbg(VFS, "Error %d during NTLMSSP allocation\n", rc);
+		*buflen = 0;
+		goto setup_ntlmv2_ret;
+	}
 	sec_blob = (AUTHENTICATE_MESSAGE *)*pbuffer;
 
 	memcpy(sec_blob->Signature, NTLMSSP_SIGNATURE, 8);