Skip to content

Commit

Permalink
econet: Use sock_orphan() instead of open-coded (and buggy) variant.
Browse files Browse the repository at this point in the history
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed Jun 17, 2008
1 parent b61d38e commit 0efffaf
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/econet/af_econet.c
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,7 @@ static int econet_release(struct socket *sock)

sk->sk_state_change(sk); /* It is useless. Just for sanity. */

sock->sk = NULL;
sk->sk_socket = NULL;
sock_set_flag(sk, SOCK_DEAD);
sock_orphan(sk);

/* Purge queues */

Expand Down

0 comments on commit 0efffaf

Please sign in to comment.