Skip to content

Commit

Permalink
Btrfs: [PATCH] extent_map: add writepage_end_io hook
Browse files Browse the repository at this point in the history
XFS updates the ondisk inode size only after the data I/O has finished,
so it needs a hook when the writepage end_bio handler has finished.

Might not be worth applying as-is as the per-page callback is very
ineffcient.  What XFS really wants is a callback when writeout of a
whole extent has completed.  This delayed i_size updates scheme might
be worthwile for btrfs aswell, btw.

Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Chris Mason <[email protected]>
  • Loading branch information
Christoph Hellwig authored and David Woodhouse committed Sep 11, 2007
1 parent b06355f commit 0e2752a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fs/btrfs/extent_map.c
Original file line number Diff line number Diff line change
Expand Up @@ -1231,6 +1231,8 @@ static int end_bio_extent_writepage(struct bio *bio,
end_page_writeback(page);
else
check_page_writeback(tree, page);
if (tree->ops && tree->ops->writepage_end_io_hook)
tree->ops->writepage_end_io_hook(page, start, end);
} while (bvec >= bio->bi_io_vec);

bio_put(bio);
Expand Down
1 change: 1 addition & 0 deletions fs/btrfs/extent_map.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ struct extent_map_ops {
int (*writepage_io_hook)(struct page *page, u64 start, u64 end);
int (*readpage_io_hook)(struct page *page, u64 start, u64 end);
int (*readpage_end_io_hook)(struct page *page, u64 start, u64 end);
void (*writepage_end_io_hook)(struct page *page, u64 start, u64 end);
};

struct extent_map_tree {
Expand Down

0 comments on commit 0e2752a

Please sign in to comment.