Skip to content

Commit

Permalink
[DECNET] ROUTE: fix rcu_dereference() uses in /proc/net/decnet_cache
Browse files Browse the repository at this point in the history
In dn_rt_cache_get_next(), no need to guard seq->private by a
rcu_dereference() since seq is private to the thread running this
function. Reading seq.private once (as guaranted bu rcu_dereference())
or several time if compiler really is dumb enough wont change the
result.
 
But we miss real spots where rcu_dereference() are needed, both in
dn_rt_cache_get_first() and dn_rt_cache_get_next()

Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Eric Dumazet authored and davem330 committed Jan 11, 2008
1 parent 5c54822 commit 0d89d79
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions net/decnet/dn_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -1665,12 +1665,12 @@ static struct dn_route *dn_rt_cache_get_first(struct seq_file *seq)
break;
rcu_read_unlock_bh();
}
return rt;
return rcu_dereference(rt);
}

static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct dn_route *rt)
{
struct dn_rt_cache_iter_state *s = rcu_dereference(seq->private);
struct dn_rt_cache_iter_state *s = seq->private;

rt = rt->u.dst.dn_next;
while(!rt) {
Expand All @@ -1680,7 +1680,7 @@ static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct dn_rou
rcu_read_lock_bh();
rt = dn_rt_hash_table[s->bucket].chain;
}
return rt;
return rcu_dereference(rt);
}

static void *dn_rt_cache_seq_start(struct seq_file *seq, loff_t *pos)
Expand Down

0 comments on commit 0d89d79

Please sign in to comment.