Skip to content

Commit

Permalink
HID: kye: Fix missing break in kye_report_fixup()
Browse files Browse the repository at this point in the history
The change to support Genius Manticore Keyboard also changed behaviour
for Genius Gx Imperator Keyboard, as there is no break between the
cases.  This is presumably a mistake.

Reported by Coverity as CID 1134029.

Fixes: 4a2c94c ('HID: kye: Add report fixup for Genius Manticore Keyboard')
Signed-off-by: Ben Hutchings <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
  • Loading branch information
bwhacks authored and Jiri Kosina committed Dec 2, 2013
1 parent 80897aa commit 0a5f99c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/hid/hid-kye.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
"Genius Gx Imperator Keyboard");
break;
case USB_DEVICE_ID_GENIUS_MANTICORE:
rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
"Genius Manticore Keyboard");
Expand Down

0 comments on commit 0a5f99c

Please sign in to comment.