Skip to content

Commit

Permalink
net/fec: carrier off initially to avoid root mount failure
Browse files Browse the repository at this point in the history
with hardware slow in negotiation, the system did freeze
while trying to mount root on nfs at boot time.

the link state has not been initialised so network stack
tried to start transmission right away. this caused instant
retries, as the driver solely stated business upon link down,
rendering the system unusable.

notify carrier off initially to prevent transmission until
phylib will report link up.

Signed-off-by: Oskar Schirmer <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Oskar Schirmer authored and davem330 committed Oct 11, 2010
1 parent 82553bb commit 03c698c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/fec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1311,6 +1311,9 @@ fec_probe(struct platform_device *pdev)
if (ret)
goto failed_mii_init;

/* Carrier starts down, phylib will bring it up */
netif_carrier_off(ndev);

ret = register_netdev(ndev);
if (ret)
goto failed_register;
Expand Down

0 comments on commit 03c698c

Please sign in to comment.