Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Clean up source code formatting #170

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

shuttle1987
Copy link
Contributor

There's a variety of inconsistent formatting in the source for this project, I've updated some old Python 2 files to be Python 2/3 compatible and run the Python files through the Black code formatting tool. Hopefully no logic is changed here.

@shuttle1987 shuttle1987 changed the title Clean up source code formatting [MRG] Clean up source code formatting Oct 6, 2019
@csukuangfj
Copy link

The original code is badly formatted, lack of documentation, hard to read and maintain.

@TParcollet
Copy link
Collaborator

PyTorch-Kaldi was intended as a functional prototype for SpeechBrain. Hence, the code does not rely one any coding guidelines, and we haven't made any video / tutorial / documentation. If you care about a clean code. Then, just wait a few months and SpeecBrain will come. That was not the purpose of PyTorch-Kaldi.

@shuttle1987
Copy link
Contributor Author

Having worked on a speech to text project myself (https://github.com/persephone-tools/persephone) I understand the value of prototypes. I think in this case the changes here will help the project as they are not designed to change any functionality but just to clean up the source code. This will make it much easier for people to read the code and learn from it. If it is possible to verify that this PR has not caused the code to break in any ways it will be a pareto efficient improvement.

@mravanelli
Copy link
Owner

Sure, thank you very much for your help! We will review it right after the upcoming ICASSP 2020 deadline (that is totally eating my time....)

@mravanelli mravanelli merged commit f9e7065 into mravanelli:master Oct 23, 2019
@mravanelli
Copy link
Owner

I checked it and it works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants