-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profile=pseudo-gui should enable warnings log when using the OSX app bundle #2547
Comments
I agree it would be nice to be able to set the logging level for the OS X app bundle, but I don't think it's because of the pseudo-gui setting. See #1590 - this is probably a dupe of that. Up until the last version or two, mpv used to write things into ~/Library/Logs/mpv.log. The content of what it wrote has changed over different versions, and there never seemed to be any way to control it. The current release doesn't write anything there anymore. You're supposed to be able to override pseudo-gui settings in mpv.conf with a [pseudo-gui] block, but I tried that and it didn't have any effect at all, for any of the options eg. screenshot-directory. So it's hard to say exactly, whether it's having any effect on the logging. The log file isn't supposed to depend on terminal verbosity or msg-level anyway, but only on -v arguments. If you specify a path with eg. [edit: For future reference, the ~/Library/Logs/mpv.log is a capture of what otherwise would be the terminal output on the command line, automatically created by the OS X mpv.app bundle. Its location can't be changed. It has nothing to do with the |
sumyungguy: as far as I know and from my testing, it is in fact because of the pseudo-gui profile configured in the app bundle. pseudo-gui defines the following: [pseudo-gui] You don't need a [pseudo-gui] block in your config file to override the settings it defines, just put them in your general config area. So if you add "terminal=yes" to your mpv.conf, suddenly it starts logging to mpv.conf, but it logs too much. So you add "msg-level=all=warn" to your mpv.conf and then it only logs the relevant warning messages that pop-up, which is the desired behaviour. Adding those 2 lines to the [pseudo-gui] profile would solve the logging issue when using the app bundle. |
Up to and including release 0.12, mpv would always write things to ~/Library/Logs/mpv.log, even without
I don't know where those messages come from, because it's not from the terminal i/o. And I don't know where they went... release 0.13 doesn't seem to write anything by default anymore, and just creates an empty log file there. I can't find anything in the changelog about it. [edit: the messages do come from the terminal i/o, and are affected by It seems you're correct that setting As far as I understand, you shouldn't be able to override the psuedo-gui profile settings in mpv.conf that way, unless you put them in a [pseudo-gui] block. The pseudo-gui section in the manual says "The profile always overrides other settings in mpv.conf." Also see #2218 for a discussion where @wm4 says allowing a config file option to override the pseudo-gui profile is not the right thing. Nevertheless you're right, it does work that way, while putting things in a [pseudo-gui] block has no effect as I mentioned. Note that none of this has anything to do with the The point is that the solution is maybe not that straightforward. Your suggestion isn't unreasonable, however:
Anyway I'm glad this came up, because now I finally understand (more or less) how to control the log file, which is something that has confounded me for a long time. The only thing I'm missing is the info about misconfigured config file options. I wonder why that's not part of the normal terminal/log-file output? |
I don't pay too much attention to mpv release versions, I've been using various git master builds since I started using mpv. I simply follow the commit log and update when something interesting comes up, or if it's been some time since my last update. But I do know that the lack of logging into mpv.log, has been around for quite some time, most likely since the introduction and use of the pseudo-gui profile. I'm pretty sure I've added the following to my config for that exact reason quite some time ago, and because I'm not a fan of the weird "smaller window->larger window" glitchy looking window resizing artifact caused by "force-window=yes". force-window=no as for when I wish to check for dropped frames, I simply open terminal and use my mpv alias, which calls: /Applications/mpv.app/Contents/MacOS/mpv --msg-level=all=status As for where I found the log, I found it in something magical called "/Applications/Utilities/Console.app", where all log files on OSX are displayed. It's an app that's been shipped with OSX since pretty much the beginning and any OSX power user should know about it. As far as warnings for misconfigured mpv.conf options, they show up in mpv.log if, you have Having it set at that level is probably what most people care about as it will only log warnings(including mis-configured mpv.conf options, like interpolation set but missing "video-sync=display-*", and won't overwhelm the log. Now as far as the pseudo-gui profile, it's configured in "mpv.app/Contents/Resources/mpv.conf" |
Did some more digging... I hadn't realized pseudo-gui was only introduced a few months ago. You're right, its The exception is that, up until some time in November, error messages about misconfigured config file options were printed anyway, because they happened before the You can restore the terminal output logging by putting The combination of some warnings being logged despite pseudo-gui being set in recent versions, and then not being logged despite Fyi, if you use I still think logging should be off unless the user turns it on, but it could be made a lot more clear in the manual how to do that. On the other hand, it doesn't make sense that it should prevent output in an interactive terminal session. Given that choice, I'd agree with having |
Location of "terminal=yes" has no impact on if it logs warnings about config file options, mine happens to also be at the very end of my config file and it correctly logs the interpolation warning when I comment out my display synch line which is close to the top of the config file. |
Your interpolation setting isn't malformed in itself, it's that it depends on another option. The check and warning about that comes from [vo/opengl] after the config file is finished being parsed. If you instead misspell "interpolation", you won't see any warnings if it's above the If I put:
into my config, then an empty log is generated. If I change the order to:
then the log contains:
This is also true if I run mpv from the command line with If the default pseudo-gui profile was altered to set I suppose I should open a separate issue about this... |
this creates a default log for the last mpv run when started from the bundle. that way one can get a log of what happened even after an issue occurred. also add a menu entry under Help to show the current log, but only when the bundle is used. Fixes mpv-player#7396 Fixes mpv-player#2547
this creates a default log for the last mpv run when started from the bundle. that way one can get a log of what happened even after an issue occurred. also add a menu entry under Help to show the current log, but only when the bundle is used. Fixes mpv-player#7396 Fixes mpv-player#2547
When mpv is used with the OSX app bundle, profile=pseudo-gui effectively disables all logging, yet an empty mpv.log gets created on launch.
This is in reference to the recent interpolation change requiring "video-sync=display-*"
A regular OSX user wouldn't immediately realize that interpolation has silently been disabled because video-sync=display-* is now required.
I suggest altering the "pseudo-gui" profile to set these 2 options, so that mpv.log actually gets populated with warnings that come up, this would at least provide some indication as to why interpolation was disabled, and whatever else may come in the future.
msg-level=all=warn
terminal=yes
The text was updated successfully, but these errors were encountered: