-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.36.0: selected application specific audio output is not remembered (by pipewire/wireplumber) #12041
Comments
This should be the same problem that #11253 tries to fix. What happens for you with this patch: diff --git a/audio/out/ao_pipewire.c b/audio/out/ao_pipewire.c
index 0a39e4e1a596..0e29f69e58a9 100644
--- a/audio/out/ao_pipewire.c
+++ b/audio/out/ao_pipewire.c
@@ -713,6 +713,7 @@ static int control(struct ao *ao, enum aocontrol cmd, void *arg)
break;
}
case AOCONTROL_UPDATE_MEDIA_ROLE: {
+ break;
enum aocontrol_media_role *role = arg;
struct spa_dict_item items[1];
const char *role_str; |
Applying the attached patch indeed appears to fix the issue for me, the selected application specific output device is remembered again. |
As the role property is interpreted by wireplumber it can only be evaluated when creating the stream. The current, dynamic mechanism is racy so revert it. See: mpv-player#11253 Fixes: mpv-player#12041 This reverts commit 535cd6f.
Important Information
Provide following Information:
/etc/mpv/mpv.conf
:issue also happens when passing
--no-config
.Reproduction steps
With mpv 0.36.0:
Expected behavior
Like with mpv 0.35.1: Have the selected audio output device for the application mpv being remembered (by pipewire/wireplumber). The reason I'm reporting this here instead of pipewire/wireplumber is the fact that when I downgrade mpv back to 0.35.1 it works like intended again and I also didn't observe this issue with other applications like browsers, games and so on.
Actual behavior
Selected audio output device for the application mpv 0.36.0 is not being remembered.
Log file
Nothing in regards to the problem is visible in the mpv logs.
Sample files
Happens with any file.
The text was updated successfully, but these errors were encountered: