Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component: ensure spec is present #103

Merged
merged 1 commit into from
Mar 6, 2020
Merged

component: ensure spec is present #103

merged 1 commit into from
Mar 6, 2020

Conversation

pyr
Copy link
Collaborator

@pyr pyr commented Mar 6, 2020

Previously, qbits.alia.component relied on qbits.alia.spec without requiring it.
Since the spec assertions are done at component build time, not runtime, there's a case for switching to throwing exceptions instead of asserting.

@mpenet mpenet merged commit 9a9ba91 into master Mar 6, 2020
@pyr pyr deleted the fix/dependencies branch March 6, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants