This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
staticanalysis/bot: For Coverity analysis when calling is_publishable also use the method defined in the base class. #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
La0
suggested changes
May 13, 2019
There was a problem hiding this comment.
To do that, you simply need to remove is_publishable from CoverityIssue. The parent class implementation will call validates: update its inner logic to match the current version and it will work.
Also the comment on is_publishable says it overrides the parent... then use it 😃
abpostelnicu
force-pushed
the
cov_in_patch
branch
2 times, most recently
from
c3e0c8d
to
9dcd25e
Compare
La0
approved these changes
May 13, 2019
… also use the method defined in the base class.
abpostelnicu
force-pushed
the
cov_in_patch
branch
from
503f939
to
6a9f9a9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid bugs like this we should also call the base method of
is_publishable.