Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

tooltool/client: more fixes due to failing tests on m-c #2084

Merged
merged 5 commits into from
May 27, 2019
Merged

tooltool/client: more fixes due to failing tests on m-c #2084

merged 5 commits into from
May 27, 2019

Conversation

garbas
Copy link
Contributor

@garbas garbas commented May 9, 2019

@garbas garbas requested a review from rail May 9, 2019 11:07
@garbas garbas requested a review from La0 as a code owner May 9, 2019 11:07
rail
rail suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to be updated as well, so we get green builds in CI

rail
rail reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@garbas garbas merged commit 332fa74 into mozilla:master May 27, 2019
@garbas garbas deleted the tooltool-client-fix branch May 27, 2019 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rail rail rail approved these changes

@La0 La0 Awaiting requested review from La0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garbas @rail