-
Notifications
You must be signed in to change notification settings - Fork 93
Big Phabricator stack fail to apply #2100
Comments
The full stack applied cleanly until the last patch. Here is the papertrail log Edit: I reproduce the bug locally 😢 |
The stack is applied on base commit 8c0a7e7ccb508dabf38dd17f66aa93bed01c0754 as this revision is found as the base of the first patch on Phabricator PHID-DIFF-mugxlbeyyulfonpdf5gl But this revision on mozilla-central misses That would imply we do not use the right base revision for that case... Edit: the patch's developper confirmed on Slack that all previous patches are merged on M-C, so the bot should check if the patch has landed, and use the latest m-c revision instead |
This is a mistake by the developer in the end, as his patch is not based on the right revision. |
Yes and No .... There is no way (that i know of) to update the base revision of the first patch in a stack. |
The right way would be for them to rebase the first patch in the stack that hasn't landed yet on top of latest mozilla-central. They are going to have to do it anyways, as otherwise they won't be able to land the patch. |
Which they have to do locally too, otherwise their patch won't even build! |
That's exactly what he did (rebase on top of MC). It's just that the bot has not that information and use a deprecated information. @Callek also got bitten by the same issue here |
This seems like an issue in moz-phab then? Why didn't it update the base revision of the patch? |
…available in the repository, fixes mozilla#2100
I made a simple patch that stops loading the stack once a base revision is found in the repository. The original revision from this issue applies with this patch |
A revision with a big stack fail to apply, pulselistener behaves accordingly and posts a failed unit test
Maybe some landed patches are applied, and give a conflict ?
The text was updated successfully, but these errors were encountered: