Build clang-format patch

[La0]

The remote workflow does not produce any clang-format diff patches anymore.
The clang-format task in-tree only produces a JSON payload compatible with our parser.

As our publication workflow does not produce inline comments for clang-format, and does not produce a patch anymore, nothing is publishable, so the bot does not publish any comment when only clang-format issues are detected on a patch. But the build status is fail !

This patch is also needed for future work on Lando, and should be available as an artifact on our task, and not from the analyzer itself (especially as we would have to run twice clang-format to get both JSON & DIFF outputs).

So we should build the diff version of the json patch in the bot.

[La0]

After discussion, it seems better to build the diff in the analyzer, as it takes the same time to build json+diff than just json (configure is reused !).

So i did a patch in mozilla-central that does just that.

I'm now working on exposing that patch from our own task

[sylvestre]

Or we could write a json to diff converter (joking) :) Le jeu. 2 mai 2019 à 15:33, Bastien Abadie <[email protected]> a écrit :

…

After discussion, it seems better to build the diff in the analyzer, as it takes the same time to build json+diff than just json (configure is reused !). So i did a patch in mozilla-central <https://phabricator.services.mozilla.com/D29662> that does just that. I'm now working on exposing that patch from our own task — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFTBDQTTK3RJK3VQTZK2ULPTLURJANCNFSM4HJ5A27Q> .

[La0]

In tree patch landed: https://hg.mozilla.org/mozilla-central/rev/f5f8345a5c87