Revert "bug(1914369): remove GRAPHICS_SANITY_TEST_REASON related code from graphics dashboard due to related deprecation in gecko-dev" #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from graphics dashboard due to related deprecation in gecko-dev"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 32.50% 32.45% -0.06%
==========================================
Files 36 36
Lines 3873 3879 +6
==========================================
Hits 1259 1259
- Misses 2614 2620 +6 ☔ View full report in Codecov by Sentry. |
BenWu
approved these changes
Sep 10, 2024
BenWu
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Actually reading the bug, SANITY_TEST_REASON might not get resolved soon so maybe we should leave it out for now and remove PLUGIN_DRAWING_MODEL, D3D11_COMPOSITING_FAILURE_ID and OPENGL_COMPOSITING_FAILURE_ID to get the job working again since we know those aren't needed
kik-kik
added
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comments in the bugzilla ticket, this should be added back and the change to gecko-dev removing this also needs to be reverted.