Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#6716) Update video placeholders #6717

Merged
merged 3 commits into from
Jan 21, 2019
Merged

(#6716) Update video placeholders #6717

merged 3 commits into from
Jan 21, 2019

Conversation

stephaniehobson
Copy link
Contributor

Description

  • updated video placeholder images for videos
  • compressed fbvideochat images since I was in there

Issue / Bugzilla link

#6716

Testing

  • Do the image show up?
  • Are they on the right videos?

@stephaniehobson
(mozilla#6716) Update video placeholders
9d417f0 
- updated video placeholder images for videos
- compressed fbvideochat images since I was in there
@stephaniehobson stephaniehobson added the Needs Review Awaiting code review label Jan 15, 2019
@alexgibson
Copy link
Member

alexgibson commented Jan 16, 2019 •
edited
Loading

The contrast on the video play icon for the top video is a bit harder to see with the new placeholder image. Could people miss that this is a clickable element?

Before:

screenshot_2019-01-16 the new fast browser for mac pc and linux firefox

After:

screenshot_2019-01-16 the new fast browser for mac pc and linux firefox 1

@alexgibson
Copy link
Member

alexgibson commented Jan 16, 2019 •
edited
Loading

I can't remember why this video is different to the rest in the way it uses a custom placeholder overlay, and not a native one. There are probably historical reasons why it's like this, but I'm not sure those reasons still exist. Could removing the custom placeholder and making the top video uniform with the other videos be a simple solution? (less code, too).

Edit: could probably remove this test, too.

@stephaniehobson
Copy link
Contributor Author

OMG yes. I assumed it was for a good reason but if there isn't one I'll update it :)

@stephaniehobson
Copy link
Contributor Author

Updated to remove custom placeholder html, script, and test for speed video.

alexgibson
alexgibson requested changes Jan 18, 2019
View reviewed changes
Copy link
Member

@alexgibson alexgibson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete fbvideochat-screenshot.jpg? This still seems to be in use.

The video test also needs removing https://github.com/mozilla/bedrock/blob/master/tests/functional/firefox/test_home.py#L20

@stephaniehobson
Copy link
Contributor Author

I don't think I deleted fbvideochat-screenshot.jpg. I did run it and fbvideochat-screenshot-high-res.jpg through tinypng to get a bit of extra compression.

@stephaniehobson
Copy link
Contributor Author

Updated to remove mute and test.

@alexgibson alexgibson merged commit 55ee94b into mozilla:master Jan 21, 2019
This was referenced Jan 21, 2019
Closed
Closed
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgibson alexgibson alexgibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephaniehobson @alexgibson