Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global FxA CTA experiment for Firefox users (Fixes #6629) #6695

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Global FxA CTA experiment for Firefox users (Fixes #6629) #6695

merged 1 commit into from
Jan 30, 2019

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 10, 2019 •
edited
Loading

Description

  • Adds a global Firefox Accounts signup button to the main navigation, shown only to Firefox users, replacing the existing download button.

Experiment cohorts:

  • Firefox (up-to-date, release channel) users on en-US locale.
    • 90% see download button (control)
    • 10% see FxA button.

Issue / Bugzilla link

#6629

Testing

  • Test using the current release version of Firefox, with DNT disabled.
  • Depending on which variant you get, a cookie is stored. You may need to clear this cookie before refreshing to see the other variant.

Demo: https://bedrock-demo-agibson.oregon-b.moz.works/en-US/

  • 10% en-US Firefox desktop users should see the FxA button.
  • 90% en-US Firefox desktop users should see the download button.
  • Non-Firefox users should always see the regular download button.
  • Experiment code should not be excecuted when switch is disabled.
  • Experiment code should not be excecuted for non en-US locales.

@alexgibson alexgibson added Do Not Merge ⚠️ P2 Second level priority - Should have WIP 🚧 Pull request is still work in progress Review: S Code review time: 30 mins to 1 hour labels Jan 10, 2019
@alexgibson alexgibson force-pushed the global-fxa-button branch 3 times, most recently from e5421e6 to da4689b Compare January 10, 2019 15:01
@claychaffin
Copy link

The copy for the experiment is:
Button
Get a Firefox Account
Text link
Check out the Benefits

@alexgibson alexgibson force-pushed the global-fxa-button branch 7 times, most recently from 48df893 to 5c69853 Compare January 15, 2019 14:01
@alexgibson alexgibson removed the WIP 🚧 Pull request is still work in progress label Jan 15, 2019
@alexgibson
Copy link
Member Author

Successful test run: https://ci.us-west.moz.works/blue/organizations/jenkins/bedrock_multibranch_pipeline/detail/run-integration-tests/236/pipeline

@alexgibson
Copy link
Member Author

Ok, this is still do-not-merge until we finalise experiment parameters, but is now code-complete enough for review.

@alexgibson
Copy link
Member Author

I believe we have all the parameters we need, this is ready.

@alexgibson
Copy link
Member Author

We may adjust the % cohorts here, so marking as DNM for now until we make a final decsion. Still good for code review.

@alexgibson alexgibson force-pushed the global-fxa-button branch 2 times, most recently from b011036 to f827367 Compare January 21, 2019 09:27
@alexgibson
Copy link
Member Author

Ok, final experiment params are all in place. This is good to merge once it finishes code review.

@alexgibson alexgibson added the P1 First level priority - Must have label Jan 24, 2019
@alexgibson alexgibson removed the P2 Second level priority - Should have label Jan 24, 2019
@craigcook craigcook self-assigned this Jan 29, 2019
craigcook
craigcook approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me the longest time to figure out why this wasn't working for me locally but was working on the demo server... after trying to debug line by line I finally realized I was in Firefox 65 but hadn't updated product details in at least a week. Doh! Ran make build, refreshed and got the account button on my second attempt. r+! 🍱

@craigcook craigcook merged commit b31f5de into mozilla:master Jan 30, 2019
@alexgibson alexgibson mentioned this pull request Jan 30, 2019
Merged
3 tasks
@amychurchwell amychurchwell mentioned this pull request Jul 12, 2019
Closed
@alexgibson alexgibson deleted the global-fxa-button branch November 15, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcook craigcook craigcook approved these changes

Assignees

@craigcook craigcook

Labels
P1 First level priority - Must have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgibson @claychaffin @craigcook