Update Indonesian What's New Page (#6472) #6630

amychurchwell · 2018-12-17T21:03:37Z

Description

Update content and design on Indonesian What's New Page.

Issue / Bugzilla link

Testing

https://bedrock-demo-id-whatsnew.oregon-b.moz.works/id/firefox/62.0/whatsnew/

craigcook · 2018-12-18T16:53:41Z

The balloon lady image is overlapping the content and it makes the left side of the form field unclickable. I think you can just do some z-index to bring the content in front.

amychurchwell · 2019-01-07T18:40:09Z

Awaiting final stakeholder approval on send_yourself email being correct. Design has been approved.

amychurchwell · 2019-01-08T15:46:24Z

Demo has been approved by stakeholder. 👍

craigcook

A few nitpicks and some things to make it look better in small viewports, but overall looking good. Nice work!

media/css/firefox/whatsnew/whatsnew-lite.scss

media/static-bundles.json

media/css/firefox/whatsnew/whatsnew-lite.scss

bedrock/firefox/templates/firefox/whatsnew/index-lite.id.html

bedrock/base/templates/macros.html

media/css/firefox/whatsnew/whatsnew-lite.scss

alexgibson · 2019-01-14T19:16:42Z

Note that this page has a test associated with it that will likely need updating. Happy to help assist here if you have any questions.

amychurchwell · 2019-01-14T22:05:53Z

Note that this page has a test associated with it that will likely need updating. Happy to help assist here if you have any questions.

Thanks Alex! For this test, would you recommend rewriting to assert for send_yourself being visible?

assert not page.is_qr_code_displayed
assert page.send_yourself.is_displayed

alexgibson · 2019-01-15T09:44:35Z

@amychurchwell Ideally it would be great to test the functionality of this new widget, like this test does here. I believe that would involve writing some new code however, since this new page uses the new send_yourself macro, and we have still to deprecate the old send_to_device widget 😕. I'd be happy to help out here, or to try and point you in the right direction. Let me know if I can help!

alexgibson

So close!

Just a couple more things, but I would push this branch to run-integration-tests just to make sure things pass before we merge.

tests/pages/firefox/whatsnew.py

tests/functional/firefox/test_whatsnew.py

alexgibson · 2019-01-17T09:05:19Z

@amychurchwell I took a look at the test failure here to try and work out what's wrong, and it looks like the failure is genuine, the form is broken 😅

If I load the page locally, enter [email protected] into the email field and hit enter, I'm presented with this raw json response:

The test is failing becuse it's expecting the thank-you message to be displayed. I'll comment in the PR as to what I think is missing here.

I guess this is why it's important to have tests! 🙂

alexgibson

The mystery test failure seems genuine. I commented as to what i think needs doing to fix the form 👍

alexgibson · 2019-01-17T09:06:53Z

media/static-bundles.json

@@ -1595,10 +1595,17 @@
    {
      "files": [
        "js/base/send-to-device.js",
+        "js/base/send-yourself.js",


There's no need to add this file to the regular firefox_whatsnew bundle, it can be removed.

alexgibson · 2019-01-17T09:19:49Z

media/static-bundles.json

        "js/firefox/whatsnew/whatsnew.js"
      ],
      "name": "firefox_whatsnew"
    },
+    {
+      "files": [
+        "js/base/send-yourself.js"


You're loading the send-yourself.js script here, but you're missing JS that initialises the form:

var form = new Mozilla.SendYourself('download-firefox-rocket'); form.init();

You'll likely need to create a new JS file like whatsnew-id.js where this gets initialized.

I noticed that the page header also seems broken, with the mozilla logo bleeding into the page:

You'll likely need to include this snippet of JS like on other whatsnew pages that shows the up-to-date message (although the logo probably shouldn't look misaligned even if this message is not displayed):

alexgibson · 2019-01-17T09:21:06Z

media/static-bundles.json

        "js/firefox/whatsnew/whatsnew.js"
      ],
      "name": "firefox_whatsnew"
    },
+    {
+      "files": [
+        "js/base/send-yourself.js"


I tried fixing the page locally, and I noticed the button on the thank-you message is unstyled:

I also had to include "js/libs/spin.min.js" in the bundle, which seems to be a dependency for send-yourself to work.

alexgibson

Spotted 2 last issues, then I think we're fine to merge 👍

tests/pages/regions/send_yourself.py

media/js/firefox/whatsnew/whatsnew-id.js

bedrock/base/templates/macros.html

alexgibson · 2019-01-18T10:06:20Z

tests/pages/regions/send_yourself.py

+class SendYourself(FirefoxBaseRegion):
+
+    _root_locator = (By.CSS_SELECTOR, '.mzp-c-sendyourself')
+    _email_locator = (By.ID, '.mzp-c-sendyourself-input')


By.CSS_SELECTOR

alexgibson · 2019-01-18T10:14:37Z

media/js/firefox/whatsnew/whatsnew-id.js

+         if (client.isFirefoxDesktop) {
+             client.getFirefoxDetails(function(data) {
+                 if (data.isUpToDate) {
+                     document.querySelector('.c-page-header').classList.add('is-up-to-date');


When testing locally, the page header still looks a bit wonky:

Looking in your CSS, it looks like the JS class to apply should be:

classList.add('show-up-to-date-message');

Even if someone views this page when their browser is not up to date, it would be nice if the Mozilla logo was still centered by default (but not a blocker).

amychurchwell added the Do Not Merge ⚠️ label Dec 17, 2018

amychurchwell force-pushed the id-whatsnew branch 3 times, most recently from 63e713d to f1050e6 Compare December 17, 2018 21:33

amychurchwell force-pushed the id-whatsnew branch 3 times, most recently from 4d562cf to 8f80b7d Compare January 7, 2019 18:27

amychurchwell added Do Not Merge ⚠️ Needs Review Awaiting code review and removed Do Not Merge ⚠️ labels Jan 7, 2019

amychurchwell removed the Do Not Merge ⚠️ label Jan 8, 2019

amychurchwell requested a review from craigcook January 8, 2019 22:36

craigcook self-assigned this Jan 9, 2019

craigcook requested changes Jan 9, 2019

View reviewed changes

amychurchwell force-pushed the id-whatsnew branch 2 times, most recently from 23cbc21 to 8cda14c Compare January 10, 2019 22:53

Update styles

4321c0d

amychurchwell force-pushed the id-whatsnew branch from 8cda14c to 4321c0d Compare January 10, 2019 22:57

Fix balloon woman scss bug

f6d82b6

Add send_yourself tests

baa0a42

alexgibson requested changes Jan 16, 2019

View reviewed changes

tests/pages/firefox/whatsnew.py Outdated Show resolved Hide resolved

tests/functional/firefox/test_whatsnew.py Show resolved Hide resolved

Debug tests

aa612bf

alexgibson requested changes Jan 17, 2019

View reviewed changes

Form bug fix

4c85298

amychurchwell force-pushed the id-whatsnew branch from 48bbcfe to 4c85298 Compare January 17, 2019 18:09

alexgibson requested changes Jan 17, 2019

View reviewed changes

tests/pages/regions/send_yourself.py Outdated Show resolved Hide resolved

media/js/firefox/whatsnew/whatsnew-id.js Show resolved Hide resolved

alexgibson reviewed Jan 17, 2019

View reviewed changes

bedrock/base/templates/macros.html Outdated Show resolved Hide resolved

Fix button contrast and JS error

7e72d11

alexgibson requested changes Jan 18, 2019

View reviewed changes

Update css selector and classname

ccdcf96

alexgibson approved these changes Jan 18, 2019

View reviewed changes

alexgibson merged commit 04ec69c into mozilla:master Jan 18, 2019

alexgibson mentioned this pull request Jan 21, 2019

404 assets on stage deployment #6730

Closed

stephaniehobson removed the Needs Review Awaiting code review label Oct 16, 2019

amychurchwell deleted the id-whatsnew branch January 10, 2020 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Indonesian What's New Page (#6472) #6630

Update Indonesian What's New Page (#6472) #6630

amychurchwell commented Dec 17, 2018 •

edited

Loading

craigcook commented Dec 18, 2018

amychurchwell commented Jan 7, 2019

amychurchwell commented Jan 8, 2019

craigcook left a comment

alexgibson commented Jan 14, 2019 •

edited

Loading

amychurchwell commented Jan 14, 2019

alexgibson commented Jan 15, 2019

alexgibson left a comment

alexgibson commented Jan 17, 2019 •

edited

Loading

alexgibson left a comment •

edited

Loading

alexgibson Jan 17, 2019 •

edited

Loading

alexgibson Jan 17, 2019 •

edited

Loading

alexgibson Jan 17, 2019

alexgibson Jan 17, 2019

alexgibson left a comment

alexgibson Jan 18, 2019

alexgibson Jan 18, 2019

Update Indonesian What's New Page (#6472) #6630

Update Indonesian What's New Page (#6472) #6630

Conversation

amychurchwell commented Dec 17, 2018 • edited Loading

Description

Issue / Bugzilla link

Testing

craigcook commented Dec 18, 2018

amychurchwell commented Jan 7, 2019

amychurchwell commented Jan 8, 2019

craigcook left a comment

Choose a reason for hiding this comment

alexgibson commented Jan 14, 2019 • edited Loading

amychurchwell commented Jan 14, 2019

alexgibson commented Jan 15, 2019

alexgibson left a comment

Choose a reason for hiding this comment

alexgibson commented Jan 17, 2019 • edited Loading

alexgibson left a comment • edited Loading

Choose a reason for hiding this comment

alexgibson Jan 17, 2019 • edited Loading

Choose a reason for hiding this comment

alexgibson Jan 17, 2019 • edited Loading

Choose a reason for hiding this comment

alexgibson Jan 17, 2019

Choose a reason for hiding this comment

alexgibson Jan 17, 2019

Choose a reason for hiding this comment

alexgibson left a comment

Choose a reason for hiding this comment

alexgibson Jan 18, 2019

Choose a reason for hiding this comment

alexgibson Jan 18, 2019

Choose a reason for hiding this comment

amychurchwell commented Dec 17, 2018 •

edited

Loading

alexgibson commented Jan 14, 2019 •

edited

Loading

alexgibson commented Jan 17, 2019 •

edited

Loading

alexgibson left a comment •

edited

Loading

alexgibson Jan 17, 2019 •

edited

Loading

alexgibson Jan 17, 2019 •

edited

Loading