Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS unit test error running on Node v10 #6681

Closed
alexgibson opened this issue Jan 7, 2019 · 0 comments
Closed

JS unit test error running on Node v10 #6681

alexgibson opened this issue Jan 7, 2019 · 0 comments
Assignees
@alexgibson
Labels
Bug 🐛 Something's not working the way it should

Comments

@alexgibson
Copy link
Member

When on the bedrock master branch and running gulp js:test locally using Node v10, the test run fails with the following error:

Firefox 64.0.0 (Mac OS X 10.14.0) mozilla-highlight-target.js isTargetAvailable should throw an error if callback is not supplied FAILED
        Error: 'it' should only be used in 'describe' function in /Users/agibson/Documents/GitHub/bedrock/node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 1117)
        @/Users/agibson/Documents/GitHub/bedrock/tests/unit/spec/base/mozilla-highlight-target.js:23:13
@alexgibson alexgibson added the Bug 🐛 Something's not working the way it should label Jan 7, 2019
@alexgibson alexgibson self-assigned this Jan 7, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Jan 7, 2019
@alexgibson
Fix JS unit test error (Fixes mozilla#6681)
234c0ef
@alexgibson alexgibson mentioned this issue Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgibson alexgibson

Labels
Bug 🐛 Something's not working the way it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexgibson