Make public_url-mismatch into a hard error. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm...I wonder if we should go even further here and forcibly re-write the WSGI environ to match what's in public_url? That would certainly reduce spurious errors but I worry that it might also mask some actual errors (e.g. telling the server it's https when it's really not) |
|
r=myself |
rfk
added a commit
that referenced
this pull request
Oct 29, 2014
…is-hard-error Make public_url-mismatch into a hard error.
Mic92
pushed a commit
to Mic92/syncserver
that referenced
this pull request
Feb 23, 2022
…ue-29 feat: refactor extractors to separate file and begin refinement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@callahad r?