This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Dashboard: Avoid unnecessary memory allocation #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go's `make` builtin allocates memory for a new object; a map of HTTP headers in this case. According to the [documentation][] for `make`, memory is allocated for map types even if the map size is omitted: > Map: An initial allocation is made according to the size but the > resulting map has length 0. The size may be omitted, in which case a > small starting size is allocated. We can safely omit the `Headers` field entirely here and avoid unnecessarily allocating memory. [documentation]: http://golang.org/pkg/builtin/#make
rafrombrc
added a commit
that referenced
this pull request
Mar 6, 2015
…_memory_allocations Dashboard: Avoid unnecessary memory allocation
relistan
pushed a commit
to Nitro/heka
that referenced
this pull request
Jan 26, 2016
…void_unnecessary_memory_allocations Dashboard: Avoid unnecessary memory allocation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's
makebuiltin allocates memory for a new object; a map ofHTTP headers in this case.
According to the documentation for
make, memory is allocated for maptypes even if the map size is omitted:
We can safely omit the
Headersfield entirely here and avoidunnecessarily allocating memory.