fixes std::bad_alloc in processPhraseTableMin for large models #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ only seems to affect the Intel compiler at O3
|
@emjotde ? |
|
No idea. Wouldn't break anything, I suppose. |
|
cheers. Merged and passes regressions tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running processPhraseTableMin with a large phrase table, I would get a std::bad_alloc error. It appears that the Intel compiler is being too aggressive in its optimizations. Adding 'volatile' to the loop variables seems to let it complete without issue. GCC doesn't have this problem.