Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorscheme for ALE plugin #170

Merged
merged 2 commits into from
Aug 12, 2017
Merged

Add colorscheme for ALE plugin #170

merged 2 commits into from
Aug 12, 2017

Conversation

ok100
Copy link
Contributor

@ok100 ok100 commented May 5, 2017

No description provided.

@polyzen
Copy link

polyzen commented May 5, 2017

Referencing #151.

@lfilho
Copy link

lfilho commented Jun 26, 2017

I did the same changes locally and was about to issue this same PR. Ha! Good job.

But I would add two extra lines regarding Info. It's already present in ALE although not implemented yet. Care to add them, @ok100 ?

" ALE: {{{

call s:HL('ALEErrorLine', s:none, s:none, s:undercurl, s:red)
call s:HL('ALEWarningLine', s:none, s:none, s:undercurl, s:yellow)
call s:HL('ALEInfoLine', s:none, s:none, s:undercurl, s:blue)

hi! link ALEErrorSign GruvboxRedSign
hi! link ALEWarningSign GruvboxYellowSign
hi! link ALEInfoSign GruvboxBlueSign

" }}}

@lfilho
Copy link

lfilho commented Jun 26, 2017

@morhetz this PR supersedes #151

@lfilho
Copy link

lfilho commented Jun 26, 2017

ALE's author has just documented these highlights: dense-analysis/ale@d5c9a4e

@lfilho
Copy link

lfilho commented Jun 28, 2017

@morhetz this is good great to go, @morhetz . Thank you very much!

@morhetz morhetz merged commit 0cd11da into morhetz:master Aug 12, 2017
@morhetz
Copy link
Owner

morhetz commented Aug 12, 2017

@lfilho
That's all thanks to @ok100
I'm just merging and reviewing that :)

@ok100
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants