Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1342 #1348

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix bug 1342 #1348

wants to merge 4 commits into from

Conversation

boppy
Copy link
Contributor

@boppy boppy commented Feb 5, 2017

Fixing #1342 by adding suggested code by @leofeyer contao/core@094e809#diff-8d2a0620105360ee4698532805680d5d plus specs.

@@ -424,6 +424,9 @@ describe('Date', function(){
it('should return the minutes as two digits', function(){
expect(d.format('%M')).toEqual('02');
});
it('should return the month as one digit', function(){
expect(d.format('%n')).toEqual('11');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not really suitable to test %n, is it? You should pick a month < 10 and make sure there is no leading 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should get some more coffee before my first commits on sundays... ;-)
Thx. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants