This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Rename RunAtomically to RunLoggedBatch #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name RunAtomically is misleading - it doesn't give atomicity in the "traditional" sense. It doesn't provide isolation (so other readers may observe inconsistent state), and it doesn't provide Read-Your-Writes consistency. That is to say, assuming the following three operations are the _only_ operations issued on the database: * A write with RunAtomically (which returns an error) * A read of the written row * A second read of the written row In some failure cases, both reads may return different values (in particular, the first read can observe the old value and the second read the new value), even if all operations were to be performed at QUORUM consistency The name RunAtomically is therefore an attractive nuisance. The name RunLoggedBatch - which takes its name from the underlying Cassandra operation - means someone is much more likely to peruse the documentation before attempting to use this Cassandra feature
milesbxf
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name RunAtomically is misleading - it doesn't give atomicity in the
"traditional" sense. It doesn't provide isolation (so other readers may
observe inconsistent state), and it doesn't provide Read-Your-Writes
consistency. That is to say, assuming the following three operations are
the only operations issued on the database:
In some failure cases, both reads may return different values (in
particular, the first read can observe the old value and the second read
the new value), even if all operations were to be performed at QUORUM
consistency
The name RunAtomically is therefore an attractive nuisance. The name
RunLoggedBatch - which takes its name from the underlying Cassandra
operation - means someone is much more likely to peruse the
documentation before attempting to use this Cassandra feature